mirror of
https://github.com/linux-apfs/apfstests.git
synced 2026-05-01 15:01:44 -07:00
Chandan Babu R
172b311e6f
xfs/{529,531,532,534,535} attempt to create test files after injecting
reduce_max_iextents error tag. Creation of test files fails when using a
multi-block directory test configuration because,
1. A directory can have a pseudo maximum extent count of 10.
2. In the worst case a directory entry creation operation can consume
(XFS_DA_NODE_MAXDEPTH + 1 + 1) * (Nr fs blocks in a single directory block)
extents.
With 1k fs block size and 4k directory block size, this evaluates to,
(5 + 1 + 1) * 4
= 7 * 4
= 28
> 10 (Pseudo maximum inode extent count).
This commit fixes the issue by creating test files before injecting
reduce_max_iextents error tag.
Reported-by: Darrick J. Wong <djwong@kernel.org>
Suggested-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
143 lines
3.1 KiB
Bash
Executable File
143 lines
3.1 KiB
Bash
Executable File
#! /bin/bash
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
# Copyright (c) 2021 Chandan Babu R. All Rights Reserved.
|
|
#
|
|
# FS QA Test 532
|
|
#
|
|
# Verify that XFS does not cause inode fork's extent count to overflow when
|
|
# adding/removing xattrs.
|
|
seq=`basename $0`
|
|
seqres=$RESULT_DIR/$seq
|
|
echo "QA output created by $seq"
|
|
|
|
here=`pwd`
|
|
tmp=/tmp/$$
|
|
status=1 # failure is the default!
|
|
trap "_cleanup; exit \$status" 0 1 2 3 15
|
|
|
|
_cleanup()
|
|
{
|
|
cd /
|
|
rm -f $tmp.*
|
|
}
|
|
|
|
# get standard environment, filters and checks
|
|
. ./common/rc
|
|
. ./common/filter
|
|
. ./common/attr
|
|
. ./common/inject
|
|
. ./common/populate
|
|
|
|
# remove previous $seqres.full before test
|
|
rm -f $seqres.full
|
|
|
|
# real QA test starts here
|
|
|
|
_supported_fs xfs
|
|
_require_scratch
|
|
_require_attrs
|
|
_require_xfs_debug
|
|
_require_test_program "punch-alternating"
|
|
_require_xfs_io_error_injection "reduce_max_iextents"
|
|
_require_xfs_io_error_injection "bmap_alloc_minlen_extent"
|
|
|
|
echo "Format and mount fs"
|
|
_scratch_mkfs_sized $((1024 * 1024 * 1024)) >> $seqres.full
|
|
_scratch_mount >> $seqres.full
|
|
|
|
bsize=$(_get_block_size $SCRATCH_MNT)
|
|
|
|
attr_len=255
|
|
|
|
testfile=$SCRATCH_MNT/testfile
|
|
|
|
echo "Consume free space"
|
|
fillerdir=$SCRATCH_MNT/fillerdir
|
|
nr_free_blks=$(stat -f -c '%f' $SCRATCH_MNT)
|
|
nr_free_blks=$((nr_free_blks * 90 / 100))
|
|
|
|
_fill_fs $((bsize * nr_free_blks)) $fillerdir $bsize 0 >> $seqres.full 2>&1
|
|
|
|
echo "Create fragmented filesystem"
|
|
for dentry in $(ls -1 $fillerdir/); do
|
|
$here/src/punch-alternating $fillerdir/$dentry >> $seqres.full
|
|
done
|
|
|
|
echo "Inject bmap_alloc_minlen_extent error tag"
|
|
_scratch_inject_error bmap_alloc_minlen_extent 1
|
|
|
|
echo "* Set xattrs"
|
|
|
|
echo "Create \$testfile"
|
|
touch $testfile
|
|
|
|
echo "Inject reduce_max_iextents error tag"
|
|
_scratch_inject_error reduce_max_iextents 1
|
|
|
|
echo "Create xattrs"
|
|
nr_attrs=$((bsize * 20 / attr_len))
|
|
for i in $(seq 1 $nr_attrs); do
|
|
attr="$(printf "trusted.%0247d" $i)"
|
|
$SETFATTR_PROG -n "$attr" $testfile >> $seqres.full 2>&1
|
|
[[ $? != 0 ]] && break
|
|
done
|
|
|
|
echo "Verify \$testfile's naextent count"
|
|
|
|
naextents=$(_xfs_get_fsxattr naextents $testfile)
|
|
if (( $naextents > 10 )); then
|
|
echo "Extent count overflow check failed: naextents = $naextents"
|
|
exit 1
|
|
fi
|
|
|
|
echo "Disable reduce_max_iextents error tag"
|
|
_scratch_inject_error reduce_max_iextents 0
|
|
|
|
echo "Remove \$testfile"
|
|
rm $testfile
|
|
|
|
echo "* Remove xattrs"
|
|
|
|
echo "Create \$testfile"
|
|
touch $testfile
|
|
|
|
echo "Create initial xattr extents"
|
|
|
|
naextents=0
|
|
last=""
|
|
start=1
|
|
nr_attrs=$((bsize / attr_len))
|
|
|
|
while (( $naextents < 4 )); do
|
|
end=$((start + nr_attrs - 1))
|
|
|
|
for i in $(seq $start $end); do
|
|
attr="$(printf "trusted.%0247d" $i)"
|
|
$SETFATTR_PROG -n $attr $testfile
|
|
done
|
|
|
|
start=$((end + 1))
|
|
|
|
naextents=$(_xfs_get_fsxattr naextents $testfile)
|
|
done
|
|
|
|
echo "Inject reduce_max_iextents error tag"
|
|
_scratch_inject_error reduce_max_iextents 1
|
|
|
|
echo "Remove xattr to trigger -EFBIG"
|
|
attr="$(printf "trusted.%0247d" 1)"
|
|
$SETFATTR_PROG -x "$attr" $testfile >> $seqres.full 2>&1
|
|
if [[ $? == 0 ]]; then
|
|
echo "Xattr removal succeeded; Should have failed "
|
|
exit 1
|
|
fi
|
|
|
|
echo "Disable reduce_max_iextents error tag"
|
|
_scratch_inject_error reduce_max_iextents 0
|
|
|
|
rm $testfile
|
|
|
|
# success, all done
|
|
status=0
|
|
exit
|