xfstests generic/306 fixes and updates

older xfs_io refused to write to /dev/null because it's
not a file on an xfs filesystem.  So add -F.

While we're at it, add more testcases:

* symlink on a RO fs pointing to a file on a RW fs.
* bind-mounted rw file on an RO fs.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
This commit is contained in:
Eric Sandeen
2013-04-29 16:09:54 +00:00
committed by Rich Johnston
parent 627427bb1b
commit f9e3015720
2 changed files with 37 additions and 3 deletions
+23 -3
View File
@@ -32,6 +32,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
_cleanup()
{
umount $BINDFILE
cd /
rm -f $tmp.*
}
@@ -49,6 +50,9 @@ _require_scratch
DEVNULL=$SCRATCH_MNT/devnull
DEVZERO=$SCRATCH_MNT/devzero
SYMLINK=$SCRATCH_MNT/symlink
BINDFILE=$SCRATCH_MNT/bindfile
TARGET=$TEST_DIR/target
rm -f $seqres.full
_scratch_mkfs > $seqres.full 2>&1
@@ -58,23 +62,39 @@ rm -f $DEVNULL $DEVZERO
mknod $DEVNULL c 1 3 || _fail "Could not create devnull device"
mknod $DEVZERO c 1 5 || _fail "Could not create devzero device"
touch $BINDFILE || _fail "Could not create bind mount file"
touch $TARGET || _fail "Could not create symlink target"
ln -s $TARGET $SYMLINK
_scratch_unmount || _fail "Could not unmount scratch device"
_scratch_mount -o ro || _fail "Could notemount scratch readonly"
_scratch_mount -o ro || _fail "Could not mount scratch readonly"
# We should be able to read & write to/from these devices even on an RO fs
echo "== try to create new file"
touch $SCRATCH_MNT/this_should_fail 2>&1 | _filter_scratch
echo "== pwrite to null device"
$XFS_IO_PROG -c "pwrite 0 512" /dev/null | _filter_xfs_io
$XFS_IO_PROG -F -c "pwrite 0 512" /dev/null | _filter_xfs_io
echo "== pread from zero device"
$XFS_IO_PROG -c "pread 0 512" /dev/zero | _filter_xfs_io
$XFS_IO_PROG -F -c "pread 0 512" /dev/zero | _filter_xfs_io
echo "== truncating write to null device"
echo foo > $DEVNULL 2>&1 | _filter_scratch
echo "== appending write to null device"
echo foo >> $DEVNULL 2>&1 | _filter_scratch
echo "== writing to symlink from ro fs to rw fs"
# Various combinations of O_CREAT & O_TRUNC
$XFS_IO_PROG -F -c "pwrite 0 512" $SYMLINK | _filter_xfs_io
$XFS_IO_PROG -F -f -c "pwrite 0 512" $SYMLINK | _filter_xfs_io
$XFS_IO_PROG -F -t -c "pwrite 0 512" $SYMLINK | _filter_xfs_io
echo "== write to bind-mounted rw file on ro fs"
mount --bind $TARGET $BINDFILE
# with and without -f (adds O_CREAT)
$XFS_IO_PROG -F -c "pwrite 0 512" $BINDFILE | _filter_xfs_io
$XFS_IO_PROG -F -f -c "pwrite 0 512" $BINDFILE | _filter_xfs_io
$XFS_IO_PROG -F -t -c "pwrite 0 512" $BINDFILE | _filter_xfs_io
# success, all done
status=0
exit