mirror of
https://github.com/linux-apfs/apfstests.git
synced 2026-05-01 15:01:44 -07:00
xfs/049: umount -d fails when kernel wins teardown race
When /etc/mtab is linked to /proc/mounts and we are using mount time created loop devices (i.e. mount -o loop), the unmount can fail with this amazingly informative error message: umount: /mnt/scratch/test2: filesystem was unmounted, but mount(8) failed: Invalid argument What it actually means in this case is that the kernel tore down the loop device when the last reference went away, and it did it so fast that mount was not able to find it in /etc/mtab after the unmount syscall. Hence it could not find the loop device it was supposed to tear down and has a hissy fit. This is simple to fix: mount does not need to tear down the loop device as the kernel does it automatically. Remove the "-d" from the umount command, and the test passes again. There's quite a few other tests that also use umount -d - fix them as well. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Brian Foster <bfoster@redhat.com> Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
committed by
Dave Chinner
parent
354108ebb9
commit
ee6ad7f578
+2
-2
@@ -36,7 +36,7 @@ _cleanup()
|
||||
{
|
||||
cd /
|
||||
rm -f $tmp.*
|
||||
umount -d $LOOP_MNT 2>/dev/null
|
||||
umount $LOOP_MNT 2>/dev/null
|
||||
rmdir $LOOP_MNT
|
||||
}
|
||||
|
||||
@@ -97,7 +97,7 @@ _grow_loop()
|
||||
$XFS_GROWFS_PROG $LOOP_MNT 2>&1 | _filter_growfs 2>&1
|
||||
|
||||
echo "*** unmount"
|
||||
umount -d $LOOP_MNT > /dev/null 2>&1
|
||||
umount $LOOP_MNT > /dev/null 2>&1
|
||||
|
||||
# Large grows takes forever to check..
|
||||
if [ "$check" -gt "0" ]
|
||||
|
||||
Reference in New Issue
Block a user