apfs/apfstests
0
0
Fork 0
mirror of https://github.com/linux-apfs/apfstests.git synced 2026-05-01 15:01:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

xfs/006: refactor reset error handling code to common/rc

Browse Source 
Nearly 1/3 code is used to reset the xfs error handling attributes,
This part can be picked up, and used for other cases. So move them
to a new function _reset_xfs_sysfs_error_handling() in common/rc.

Signed-off-by: Zorro Lang <zlang@redhat.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
This commit is contained in:
Zorro Lang
2016-08-20 01:56:31 +08:00
committed by Eryu Guan
parent 9c03808e4d
commit d88e01fa78
3 changed files with 45 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/rc
+37
View File
@@ -3890,6 +3890,43 @@ _get_fs_sysfs_attr()
cat /sys/fs/${FSTYP}/${dname}/${attr}
}
# Reset all xfs error handling attributes, set them to original
# status.
#
# Only one argument, and it's mandatory:
# - dev: device name, e.g. $SCRATCH_DEV
#
# Note: this function only works for XFS
_reset_xfs_sysfs_error_handling()
{
local dev=$1
if [ ! -b "$dev" -o "$FSTYP" != "xfs" ];then
_fail "Usage: reset_xfs_sysfs_error_handling <device>"
fi
_set_fs_sysfs_attr $dev error/fail_at_unmount 1
echo -n "error/fail_at_unmount="
_get_fs_sysfs_attr $dev error/fail_at_unmount
# Make sure all will be configured to retry forever by default, except
# for ENODEV, which is an unrecoverable error, so it will be configured
# to not retry on error by default.
for e in default EIO ENOSPC; do
_set_fs_sysfs_attr $dev \
error/metadata/${e}/max_retries -1
echo -n "error/metadata/${e}/max_retries="
_get_fs_sysfs_attr $dev error/metadata/${e}/max_retries
_set_fs_sysfs_attr $dev \
error/metadata/${e}/retry_timeout_seconds 0
echo -n "error/metadata/${e}/retry_timeout_seconds="
_get_fs_sysfs_attr $dev \
error/metadata/${e}/retry_timeout_seconds
done
}
# Skip if we are running an older binary without the stricter input checks.
# Make multiple checks to be sure that there is no regression on the one
# selected feature check, which would skew the result.