apfs/apfstests
0
0
Fork 0
mirror of https://github.com/linux-apfs/apfstests.git synced 2026-05-01 15:01:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

common: Add _require_no_xfs_bug_on_assert and factor out filter_xfs_dmesg

Browse Source 
1) Introduce _require_no_xfs_bug_on_assert helper to check if XFS is
   built with CONFIG_XFS_ASSERT_FATAL, and call _require_no_xfs_debug
   if bug_on_assert is not available.

2) Apply _require_no_xfs_bug_on_assert in xfs/098 and xfs/115.

3) Move filter_xfs_dmesg from xfs/098 to common/filter, and rename
   it as _filter_assert_dmesg.

[eguan: update comment and _notrun message a bit]

Signed-off-by: xiao yang <yangx.jy@cn.fujitsu.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
This commit is contained in:
xiao yang
2018-01-19 13:38:05 +08:00
committed by Eryu Guan
parent 21e7398203
commit a3b3cf68fb
4 changed files with 41 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/xfs
+22
View File
@@ -625,6 +625,28 @@ _require_no_xfs_debug()
fi
}
# Require that assertions will not crash the system.
#
# Assertions would always crash the system if XFS assert fatal was enabled
# (CONFIG_XFS_ASSERT_FATAL=y). If a test is designed to trigger an assertion,
# skip the test on a CONFIG_XFS_ASSERT_FATAL built XFS by default. Note:
# CONFIG_XFS_ASSERT_FATAL can be disabled by setting bug_on_assert to zero if
# we want test to run.
_require_no_xfs_bug_on_assert()
{
if [ -f /sys/fs/xfs/debug/bug_on_assert ]; then
grep -q "1" /sys/fs/xfs/debug/bug_on_assert && \
_notrun "test requires XFS bug_on_assert to be off, turn it off to run the test"
else
# Note: Prior to the creation of CONFIG_XFS_ASSERT_FATAL (and
# the sysfs knob bug_on_assert), assertions would always crash
# the system if XFS debug was enabled (CONFIG_XFS_DEBUG=y). If
# a test is designed to trigger an assertion and the test
# designer does not want to hang fstests, skip the test.
_require_no_xfs_debug
fi
}
# Get a metadata field
# The first arg is the field name
# The rest of the arguments are xfs_db commands to find the metadata.