mirror of
https://github.com/linux-apfs/apfstests.git
synced 2026-05-01 15:01:44 -07:00
new: validate groups when creating new test
Allow only lower case letters, digits, spaces and underscore when adding groups, give prompt if there's any not-allowed characters. Also remove redundant spaces between groups. Reviewed-by: Brian Foster <bfoster@redhat.com> Signed-off-by: Eryu Guan <eguan@redhat.com>
This commit is contained in:
@@ -239,7 +239,7 @@ then
|
||||
|
||||
while true
|
||||
do
|
||||
echo -n "Add to group(s) [other] (? for list): "
|
||||
echo -n "Add to group(s) [other] (separate by space, ? for list): "
|
||||
read ans
|
||||
[ -z "$ans" ] && ans=other
|
||||
if [ "X$ans" = "X?" ]
|
||||
@@ -254,7 +254,17 @@ then
|
||||
lst=`for word in $grpl; do echo $word; done | sort| uniq `
|
||||
echo $lst
|
||||
else
|
||||
break
|
||||
# only allow lower cases, spaces, digits and underscore in group
|
||||
inval=`echo $ans | tr -d '[:lower:][:space:][:digit:]_'`
|
||||
if [ "$inval" != "" ]; then
|
||||
echo "Invalid characters in group(s): $inval"
|
||||
echo "Only lower cases, digits and underscore are allowed in groups, separated by space"
|
||||
continue
|
||||
else
|
||||
# remove redundant spaces/tabs
|
||||
ans=`echo "$ans" | sed 's/\s\+/ /g'`
|
||||
break
|
||||
fi
|
||||
fi
|
||||
done
|
||||
else
|
||||
|
||||
Reference in New Issue
Block a user