defrag: loosen input file requirements

We don't have perfect control of file allocation for these tests;
in some cases we may fail to adequately fragment a file prior to
defragmentation testing, and today that will fail the test.

Attack this on 2 fronts:

1) Explicitly allow fewer extents on one of the input files in
   generic/018 where the allocator has discretion.
2) _notrun rather than _fail if we don't create enough extents;
   this is a defrag test, not an allocator/fragmentation test,
   so just skip the test if we can't create an acceptable file
   for defrag testing.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Acked-by: Dmitry Monakhov <dmonakhov@openvz.org>
Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
Eric Sandeen
2015-12-21 18:01:47 +11:00
committed by Dave Chinner
parent a3d2994caa
commit 84f48144dd
3 changed files with 18 additions and 5 deletions
+14 -3
View File
@@ -53,15 +53,24 @@ _check_extent_count()
max=$2
ext_cnt=$3
[ "$min" -gt "$ext_cnt" ] && _fail "Found $ext_cnt extents min:$max"
[ "$max" -ne -1 ] && [ "$ext_cnt" -gt "$max" ] && _fail "Found $ext_cnt max: $max"
# Return failure if $3 isn't between $1 and $2; let caller decide
# action if it's not, we just return status here.
if [ "$min" -gt "$ext_cnt" ]; then
echo "Found $ext_cnt extents min:$max"
return 1;
fi
if [ "$max" -ne -1 ] && [ "$ext_cnt" -gt "$max" ]; then
echo "Found $ext_cnt max: $max"
return 1;
fi
if [ $max -ne $min ]; then
echo "in_range($min, $max)"
else
echo "$ext_cnt"
fi
return $ext_cnt
# success
return 0
}
# Defrag file, check it, and remove it.
@@ -129,6 +138,7 @@ _defrag()
echo -n "Before: "
ext_before=$(_extent_count $1)
_check_extent_count $min_before $max_before $ext_before
[ $? -eq 0 ] || _notrun "Could not adequately fragment file"
[ ! -z $csum ] && CSUM_BEFORE=`md5sum $1`
STAT_BEFORE=`stat -c "a: %x m: %y c: %z" $1`
@@ -141,6 +151,7 @@ _defrag()
echo -n "After: "
ext_after=$(_extent_count $1)
_check_extent_count $min_after $max_after $ext_after
[ $? -eq 0 ] || _fail "Failed to adequately defragment file"
[ "$ext_before" -lt "$ext_after" ] && \
_fail "Number of extents increased after defragmentation," \