apfs/apfstests
0
0
Fork 0
mirror of https://github.com/linux-apfs/apfstests.git synced 2026-05-01 15:01:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

common/xfs: wipe the XFS superblock of each AGs

Browse Source 
xfs/030 always fails after d0e484ac69 ("check: wipe scratch devices
between tests") get merged.

Due to xfs/030 does a sized(100m) mkfs. Before we merge above commit,
mkfs.xfs detects an old primary superblock, it will write zeroes to
all superblocks before formatting the new filesystem. But this won't
be done if we wipe the first superblock(by merging above commit).

That means if we make a (smaller) sized xfs after wipefs, those *old*
superblocks which created by last time mkfs.xfs will be left on disk.
Then when we do xfs_repair, if xfs_repair can't find the first SB, it
will go to find those *old* SB at first. When it finds them,
everyting goes wrong.

So I try to wipe each XFS superblock if there's a XFS ondisk, then
try to erase superblock of each XFS AG by default mkfs.xfs geometry.
Thanks Darrick J. Wong helped to analyze this issue.

Reported-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Signed-off-by: Zorro Lang <zlang@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
This commit is contained in:
Zorro Lang
2019-09-24 18:09:19 +08:00
committed by Eryu Guan
parent b727d8af32
commit 7ddb754f15
2 changed files with 48 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/rc
+8
View File
@@ -4045,6 +4045,14 @@ _try_wipe_scratch_devs()
{
test -x "$WIPEFS_PROG" || return 0
# Do specified filesystem wipe at first
case "$FSTYP" in
"xfs")
_try_wipe_scratch_xfs
;;
esac
# Then do wipefs on all scratch devices
for dev in $SCRATCH_DEV_POOL $SCRATCH_DEV $SCRATCH_LOGDEV $SCRATCH_RTDEV; do
test -b $dev && $WIPEFS_PROG -a $dev
done
common/xfs
+40
View File
@@ -884,3 +884,43 @@ _xfs_mount_agcount()
{
$XFS_INFO_PROG "$1" | grep agcount= | sed -e 's/^.*agcount=\([0-9]*\),.*$/\1/g'
}
# Wipe the superblock of each XFS AGs
_try_wipe_scratch_xfs()
{
local num='^[0-9]+$'
local agcount
local agsize
local dbsize
# Try to wipe each SB if there's an existed XFS
agcount=`_scratch_xfs_get_sb_field agcount 2>/dev/null`
agsize=`_scratch_xfs_get_sb_field agblocks 2>/dev/null`
dbsize=`_scratch_xfs_get_sb_field blocksize 2>/dev/null`
if [[ $agcount =~ $num && $agsize =~ $num && $dbsize =~ $num ]];then
for ((i = 0; i < agcount; i++)); do
$XFS_IO_PROG -c "pwrite $((i * dbsize * agsize)) $dbsize" \
$SCRATCH_DEV >/dev/null;
done
fi
# Try to wipe each SB by default mkfs.xfs geometry
local tmp=`mktemp -u`
unset agcount agsize dbsize
_scratch_mkfs_xfs -N 2>/dev/null | perl -ne '
if (/^meta-data=.*\s+agcount=(\d+), agsize=(\d+) blks/) {
print STDOUT "agcount=$1\nagsize=$2\n";
}
if (/^data\s+=\s+bsize=(\d+)\s/) {
print STDOUT "dbsize=$1\n";
}' > $tmp.mkfs
. $tmp.mkfs
if [[ $agcount =~ $num && $agsize =~ $num && $dbsize =~ $num ]];then
for ((i = 0; i < agcount; i++)); do
$XFS_IO_PROG -c "pwrite $((i * dbsize * agsize)) $dbsize" \
$SCRATCH_DEV >/dev/null;
done
fi
rm -f $tmp.mkfs
}