apfs/apfstests
0
0
Fork 0
mirror of https://github.com/linux-apfs/apfstests.git synced 2026-05-01 15:01:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

shared/272: don't try to use O_DIRECT

Browse Source 
A comment in shared/272 claims that ext4 supports O_DIRECT in
data=journalling mode.  Actually, it doesn't, it was just silently
ignoring O_DIRECT, let's not try to test O_DIRECT for either ext3 or
ext4 in this test.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
This commit is contained in:
Theodore Ts'o
2016-06-09 14:42:31 -04:00
committed by Eryu Guan
parent 2d59a75d91
commit 795ea36a18
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/shared/272
+1 -3
View File
@@ -31,10 +31,8 @@ tmp=/tmp/$$
status=1 # failure is the default!
trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
# ext3 doesn't support direct IO in journalling mode
# ext3 and ext4 don't support direct IO in journalling mode
write_opt_list="iflag=noatime conv=notrunc conv=fsync"
# For filesystems that can handle it, add also direct IO test
[ $FSTYP = "ext4" ] && write_opt_list="$write_opt_list oflag=direct"
# get standard environment, filters and checks
. ./common/rc