apfs/apfstests
0
0
Fork 0
mirror of https://github.com/linux-apfs/apfstests.git synced 2026-05-01 15:01:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

xfs/073: avoid finobt warning from mkfs

Browse Source 
When testing xfs/073 with MKFS_OPTIONS="-m crc=1,finobt=1" set, it fails
due to extra warning about disabling finobt feature:

 +warning: finobt not supported without CRC support, disabled.

Because xfs/073 disables crc unconditionally and finobt can not be
enabled either.

Fix it by explicitly disabling finobt as well.

Also remove all meta related mkfs options in _scratch_mkfs_xfs_opts() if
mkfs.xfs has no metadata support, not only the crc option. So that test
still passes on distros with such old binaries.

Suggested-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Eryu Guan <eguan@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
Eryu Guan
2016-03-23 17:39:11 +11:00
committed by Dave Chinner
parent 2c1896a44c
commit 5af5146ef1
3 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/rc
+2 -2
View File
@@ -444,9 +444,9 @@ _scratch_mkfs_xfs_opts()
{
mkfs_opts=$*
# remove crc related mkfs options if mkfs.xfs doesn't support v5 xfs
# remove metadata related mkfs options if mkfs.xfs doesn't them
if [ -n "$XFS_MKFS_HAS_NO_META_SUPPORT" ]; then
mkfs_opts=`echo $mkfs_opts | sed "s/-m\s\+crc=.//"`
mkfs_opts=`echo $mkfs_opts | sed "s/-m\s\+\S\+//g"`
fi
_scratch_options mkfs