common/rc: add missing 'local' keywords

Browse Source

Many helper functions in xfstests are unnecessarily declaring variables
without the 'local' keyword, which pollutes the global namespace and can
collide with variables in tests.  Fix this for everything in common/rc
that I could find.

In _math(), just eliminate $result by removing the check for nonempty
$BC, which is redundant with _require_math() which the tests do.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Eryu Guan <guaneryu@gmail.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>

...

This commit is contained in:

Eric Biggers

2018-04-06 19:35:29 -07:00

committed by Eryu Guan

parent 4cabd42a78

commit 1ddae54555

1 changed files with 154 additions and 145 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

common/rc

+154 -145

File diff suppressed because it is too large Load Diff