overlay: work dir in overlay inherits no ACLs

They should be cleaned while mounting overlayfs.

[eguan: remove uncorrect comments about getfacl filter]

CC: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Xiong Zhou <xzhou@redhat.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
This commit is contained in:
Xiong Zhou
2017-02-23 17:42:40 +08:00
committed by Eryu Guan
parent 2233529462
commit 1cd821c2c3
3 changed files with 86 additions and 0 deletions
+77
View File
@@ -0,0 +1,77 @@
#! /bin/bash
# FS QA Test 023
#
# The "work" directory in an overlyfs workdir should not inherit
# ACL attrs from workdir.
# Kernel commits below fix it.
# c11b9fdd6a61 ovl: remove posix_acl_default from workdir
# e1ff3dd1ae52 ovl: fix workdir creation
#
# This reproducer was originally written by
# Miklos Szeredi <mszeredi@redhat.com>
#
#-----------------------------------------------------------------------
# Copyright (c) 2017 Red Hat Inc. All Rights Reserved.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License as
# published by the Free Software Foundation.
#
# This program is distributed in the hope that it would be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
#-----------------------------------------------------------------------
#
seq=`basename $0`
seqres=$RESULT_DIR/$seq
echo "QA output created by $seq"
here=`pwd`
tmp=/tmp/$$
status=1 # failure is the default!
trap "_cleanup; exit \$status" 0 1 2 3 15
_cleanup()
{
cd /
rm -f $tmp.*
}
# get standard environment, filters and checks
. ./common/rc
. ./common/filter
. ./common/attr
# remove previous $seqres.full before test
rm -f $seqres.full
# real QA test starts here
# Modify as appropriate.
_supported_fs overlay
_supported_os Linux
_require_acls
_require_scratch
# Remove all files from previous tests
_scratch_mkfs
# setting acls before mount
wkdir=$SCRATCH_DEV/$OVERLAY_WORK_DIR
mkdir -p $wkdir
setfacl -d -m o::rwx $wkdir
_scratch_mount
# getting acls, ACL set on workdir should be cleaned
getfacl -p $wkdir/work 2>&1 | _filter_scratch
# success, all done
status=0
exit
+8
View File
@@ -0,0 +1,8 @@
QA output created by 023
# file: SCRATCH_DEV/work/work
# owner: root
# group: root
user::---
group::---
other::---
+1
View File
@@ -25,3 +25,4 @@
020 auto quick copyup perms
021 auto quick copyup
022 auto quick
023 auto quick attr