apfs/apfstests
0
0
Fork 0
mirror of https://github.com/linux-apfs/apfstests.git synced 2026-05-01 15:01:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

generic/158,304: filter dedupe error message

Browse Source 
Kernel commit 22725ce4e4a0 ("vfs: fix isize/pos/len checks for reflink &
dedupe") added more checks on reflink and dedupe, rejected dedupe past
EOF early and explicitly, and causes generic/158 and generic/304 to fail.

  Try dedupe from past EOF
 -dedupe: Invalid argument
 +XFS_IOC_FILE_EXTENT_SAME: Invalid argument
  Try dedupe to past EOF, destination offset beyond EOF

Also there's an xfsprogs patch from Darrick ("xfs_io: prefix dedupe
command error messages consistently") to change all xfs_io dedupe
error message prefixes to "XFS_IOC_FILE_EXTENT_SAME".

So introduce a new _filter_dedupe_error, change all "dedupe" prefix
to XFS_IOC_FILE_EXTENT_SAME, make tests pass with both old/new
kernel & userspace.

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
This commit is contained in:
Eryu Guan
2016-12-30 11:34:19 +08:00
parent a1d861da98
commit 1300cbc873
5 changed files with 53 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/generic/304
+14 -7
View File
@@ -63,25 +63,32 @@ _pwrite_byte 0x61 $bigoff 1 $testdir/file3 >> $seqres.full
_pwrite_byte 0x61 1048575 1 $testdir/file2 >> $seqres.full
echo "Dedupe large single byte file"
_dedupe_range $testdir/file1 0 $testdir/file3 0 $len >> $seqres.full
_dedupe_range $testdir/file1 0 $testdir/file3 0 $len \
2>&1 >> $seqres.full | _filter_dedupe_error
echo "Dedupe large empty file"
_dedupe_range $testdir/file0 0 $testdir/file4 0 $len >> $seqres.full
_dedupe_range $testdir/file0 0 $testdir/file4 0 $len \
2>&1 >> $seqres.full | _filter_dedupe_error
echo "Dedupe past maximum file size in dest file (should fail)"
_dedupe_range $testdir/file1 0 $testdir/file5 4611686018427322368 $len >> $seqres.full
_dedupe_range $testdir/file1 0 $testdir/file5 4611686018427322368 $len \
2>&1 >> $seqres.full | _filter_dedupe_error
echo "Dedupe high offset to low offset"
_dedupe_range $testdir/file1 $bigoff_64k $testdir/file6 1048576 65535 >> $seqres.full
_dedupe_range $testdir/file1 $bigoff_64k $testdir/file6 1048576 65535 \
2>&1 >> $seqres.full | _filter_dedupe_error
echo "Dedupe past source file EOF (should fail)"
_dedupe_range $testdir/file2 524288 $testdir/file7 0 1048576 >> $seqres.full
_dedupe_range $testdir/file2 524288 $testdir/file7 0 1048576 \
2>&1 >> $seqres.full | _filter_dedupe_error
echo "Dedupe max size at nonzero offset (should fail)"
_dedupe_range $testdir/file2 524288 $testdir/file8 0 $len >> $seqres.full
_dedupe_range $testdir/file2 524288 $testdir/file8 0 $len \
2>&1 >> $seqres.full | _filter_dedupe_error
echo "Dedupe with huge off/len (should fail)"
_dedupe_range $testdir/file2 $bigoff_64k $testdir/file9 0 $bigoff_64k >> $seqres.full
_dedupe_range $testdir/file2 $bigoff_64k $testdir/file9 0 $bigoff_64k \
2>&1 >> $seqres.full | _filter_dedupe_error
echo "Check file creation"
_test_cycle_mount