generic: test mapped write after shutdown and failed writeback

XFS has a regression where it failed to check shutdown status in the
write fault path. This produced an iomap warning if the page
happened to recently fail a writeback attempt because writeback
failure can clear Uptodate status on the page.

Add a test for this scenario to help ensure mapped write failures
are handled as expected in the event of filesystem shutdown.
Upstream commit e4826691cc7e ("xfs: restore shutdown check in mapped
write fault path") fixed this bug.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
This commit is contained in:
Brian Foster
2021-02-10 12:06:28 -05:00
committed by Eryu Guan
parent 8cbc48b460
commit 011bfb01f7
3 changed files with 50 additions and 0 deletions
+45
View File
@@ -0,0 +1,45 @@
#! /bin/bash
# SPDX-License-Identifier: GPL-2.0-only
# Copyright 2021 Red Hat, Inc.
#
# FS QA Test No. 623
#
# Test a write fault scenario on a shutdown fs.
#
seq=`basename $0`
seqres=$RESULT_DIR/$seq
echo "QA output created by $seq"
here=`pwd`
tmp=/tmp/$$
status=1 # failure is the default!
trap "_cleanup; exit \$status" 0 1 2 3 15
_cleanup()
{
rm -f $tmp.*
}
. ./common/rc
. ./common/filter
rm -f $seqres.full
_supported_fs generic
_require_scratch_nocheck
_require_scratch_shutdown
_scratch_mkfs &>> $seqres.full
_scratch_mount
# XFS had a regression where it failed to check shutdown status in the fault
# path. This produced an iomap warning because writeback failure clears Uptodate
# status on the page.
file=$SCRATCH_MNT/file
$XFS_IO_PROG -fc "pwrite 0 4k" -c fsync $file | _filter_xfs_io
$XFS_IO_PROG -x -c "mmap 0 4k" -c "mwrite 0 4k" -c shutdown -c fsync \
-c "mwrite 0 4k" $file | _filter_xfs_io
# success, all done
status=0
exit
+4
View File
@@ -0,0 +1,4 @@
QA output created by 623
wrote 4096/4096 bytes at offset 0
XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
fsync: Input/output error
+1
View File
@@ -625,3 +625,4 @@
620 auto mount quick
621 auto quick encrypt
622 auto shutdown metadata atime
623 auto quick shutdown