mirror of
https://github.com/AdaCore/git-hooks.git
synced 2026-02-12 12:43:11 -08:00
a1ab32afb3
This function starts by an assertion that the given parameter is a string by checking its type. However, in Python 2, strings can take 2 forms: type "str", or type "unicode". What we'd like to do to help migrating this code to Python, is to start using unicode strings throughout. But then, if we want to keep the assertion, the problem becomes that we would need to change it to check for type "unicode", which would be incompatible with Python 3, where type "unicode" no longer exists. Since the assertion is not really all that helpful and even possibly unnecessarily restrictive, this commit simply removes it. Change-Id: If9014c35b5f2107cfc0bb03338b9a977f44587ba
70 lines
2.0 KiB
Python
70 lines
2.0 KiB
Python
"""A number of utility functions performing type conversions...
|
|
"""
|
|
|
|
|
|
def to_bool(val):
|
|
"""Translate val into a either True or False.
|
|
|
|
Raise ValueError if val cannot be converted.
|
|
|
|
PARAMETERS
|
|
val: The value to convert. It can be either a boolean,
|
|
in which case this function is a no-op, or a string
|
|
whose (lowercase) value must then be either 'true'
|
|
or 'false'.
|
|
|
|
REMARKS
|
|
It would be nice if we could have used the bool builtin
|
|
function, but this function unfortunately returns something
|
|
different: It applies the truth test on the argument, and
|
|
then returns the result of that test. In other words,
|
|
bool("False") returns True!
|
|
"""
|
|
if val in (True, False):
|
|
return val
|
|
val_str = str(val).lower()
|
|
if val_str == "true":
|
|
return True
|
|
if val_str == "false":
|
|
return False
|
|
raise ValueError("invalid boolean value: '%s'", str(val))
|
|
|
|
|
|
def to_tuple(val):
|
|
"""Translate val into a tuple.
|
|
|
|
PARAMETERS
|
|
val: The value to convert, assumed to be a string for now.
|
|
|
|
REMARKS
|
|
Handling of val being a tuple, or even maybe other types
|
|
could be added as well. But there is no need for it at
|
|
the moment.
|
|
"""
|
|
# Handle the case where val is empty separately, as split would
|
|
# return a tuple containing an empty string. We want to return
|
|
# an empty tuple in this case.
|
|
if not val:
|
|
return ()
|
|
return tuple(val.split(","))
|
|
|
|
|
|
def to_type(val, new_type):
|
|
"""Translate val to the given type.
|
|
|
|
Raise ValueError if val cannot be converted.
|
|
|
|
PARAMETERS
|
|
val: The value to convert.
|
|
new_type: A callable that indicates the new type for the value.
|
|
Usually one of the built-in functions such as 'int', or
|
|
'bool', etc.
|
|
"""
|
|
# Most of the built-ins perform a translation job, but there
|
|
# are some exceptions...
|
|
if new_type == bool:
|
|
new_type = to_bool
|
|
elif new_type == tuple:
|
|
new_type = to_tuple
|
|
return new_type(val)
|