This function starts by an assertion that the given parameter is
a string by checking its type. However, in Python 2, strings can
take 2 forms: type "str", or type "unicode". What we'd like to do
to help migrating this code to Python, is to start using unicode
strings throughout. But then, if we want to keep the assertion,
the problem becomes that we would need to change it to check for
type "unicode", which would be incompatible with Python 3, where
type "unicode" no longer exists.
Since the assertion is not really all that helpful and even
possibly unnecessarily restrictive, this commit simply removes it.
Change-Id: If9014c35b5f2107cfc0bb03338b9a977f44587ba
The purpose is to allow config.git_config to handle the config
options which are comma-separated lists automatically.
This is just the framework part. Options will be converted
one by one.
This patch allows us to specify a given type to any git config
option, and have git_config config the option value (a string)
into that type, raising an InvalidUpdate error if the conversion
failed.
Currently no such option is taking advantage of this features.
Transition of the relevant options will be done piecemeal.
Part of LC27-007.