Files
cpython/Python
Anthony Baxter 911933704e backport tim_one's patch:
Repair widespread misuse of _PyString_Resize.  Since it's clear people
don't understand how this function works, also beefed up the docs.  The
most common usage error is of this form (often spread out across gotos):

	if (_PyString_Resize(&s, n) < 0) {
		Py_DECREF(s);
		s = NULL;
		goto outtahere;
	}

The error is that if _PyString_Resize runs out of memory, it automatically
decrefs the input string object s (which also deallocates it, since its
refcount must be 1 upon entry), and sets s to NULL.  So if the "if"
branch ever triggers, it's an error to call Py_DECREF(s):  s is already
NULL!  A correct way to write the above is the simpler (and intended)

	if (_PyString_Resize(&s, n) < 0)
		goto outtahere;

Bugfix candidate.

Original patch(es):
python/dist/src/Python/bltinmodule.c:2.253
2002-04-30 04:05:33 +00:00
..
2000-05-02 18:34:30 +00:00
2002-04-30 04:05:33 +00:00
2002-03-28 20:18:48 +00:00
2002-01-23 15:53:08 +00:00
2002-01-28 15:13:21 +00:00
2002-02-27 13:31:58 +00:00
2001-11-09 22:02:48 +00:00
2002-03-25 12:33:56 +00:00
2001-11-28 22:07:30 +00:00
2002-03-05 13:56:23 +00:00
2002-03-29 14:47:18 +00:00